Skip to content

Create T-all zulip user group #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Create T-all zulip user group #1969

wants to merge 2 commits into from

Conversation

jieyouxu
Copy link
Member

This is needed to configure the infra announcement channel so the zulip user group membership is synced automatically with project team membership.

This notably does not include working groups, project groups, or marker teams. The cloud-compute marker team will need its own zulip user group in a follow-up.

See #t-infra > Communication method for dev desktops @ 💬 for more details.

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. T-infra Relevant to the infrastructure team. labels Aug 30, 2025
@jieyouxu jieyouxu mentioned this pull request Aug 30, 2025
Open
@jieyouxu jieyouxu added S-blocked Status: blocked and removed S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Aug 30, 2025
@jieyouxu
Copy link
Member Author 

[ERROR rust_team::validate] validation error: person `KannanPalani57` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `SimonSapin` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `U007D` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `adityac8` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `andrewpollack` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `arshiamufti` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `badboy` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `bdillo` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `bnchi` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `cdmistman` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `celaus` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `ericseppanen` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `extrawurst` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `flaki` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `ibraheemdev` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `manyinsects` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `mariannegoldin` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `marioidival` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `mattgathu` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `opeolluwa` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `sebasmagri` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `spacekookie` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `sunfishcode` in 'all' is a member of a Zulip user group but has no Zulip id
[ERROR rust_team::validate] validation error: person `wezm` in 'all' is a member of a Zulip user group but has no Zulip id

@jieyouxu jieyouxu marked this pull request as draft August 30, 2025 05:08
@jieyouxu
Create T-all zulip user group
8c96074 
This is needed to configure the infra announcement channel so the zulip
user group membership is synced automatically with project team
membership.

This notably does not include working groups, project groups, or marker
teams. The cloud-compute marker team will need its own zulip user group
in a follow-up.
@jieyouxu
Exclude all members without zulip id from zulip group
46df291
@jieyouxu jieyouxu force-pushed the infra-announcement-all branch from b344a00 to 46df291 Compare September 15, 2025 11:55
@Kobzol
Copy link
Member

Kobzol commented Sep 26, 2025 •
edited
Loading

I would perhaps rather have an (either implicit or explicit) opt-out of the Zulip ID check for t-all specifically. Otherwise every new team member added without a Zulip ID will trigger the Zulip check on this team. That being said, if we wanted to make Zulip membership "more mandatory", then that would actually be nice.

@traviscross
Copy link
Contributor

traviscross commented Sep 26, 2025 •
edited
Loading

That being said, if we wanted to make Zulip membership "more mandatory", then that would actually be nice.

We have recently been moving things that weren't on Zulip to Zulip. I wonder if maybe we are at or near the point we could do this.

@Kobzol
Copy link
Member

Kobzol commented Sep 26, 2025

I don't know if everyone in team is actively on Zulip (most likely not), and we still didn't resolve the wg-embedded situation, which is an organization that is currently in team, and we kind of manage their GitHub repos, but they are completely separate and operate mostly on Matrix.

But at least from a technical point of view, I think that requiring people in team to have an associated Zulip handle (even if they don't actually actively use Zulip) would not be such a problem, especially since it's quite easy to create a Zulip account using a GitHub account, which we already require for everyone. So we could say that to be in the Project, you must have GitHub + Zulip (while now it's just GitHub).

@jieyouxu
Copy link
Member Author

jieyouxu commented Oct 2, 2025 •
edited
Loading

I would perhaps rather have an (either implicit or explicit) opt-out of the Zulip ID check for t-all specifically. Otherwise every new team member added without a Zulip ID will trigger the Zulip check on this team. That being said, if we wanted to make Zulip membership "more mandatory", then that would actually be nice.

Okay, that sounds reasonable. Though I think that change will need to land after #1977.

Requiring everyone to have a zulip-id seems reasonable as well, though I'd defer that decision to the council. For this purpose, we can just use the T-all-won't-hard-require-everyone-to-have-zulip-id I suppose. Do you think we should nominate this for the council, or should we just go with T-all-is-special for now?

This was referenced Oct 2, 2025
Open
Draft
@jieyouxu jieyouxu added the T-leadership-council Relevant to the leadership council. label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-blocked Status: blocked T-infra Relevant to the infrastructure team. T-leadership-council Relevant to the leadership council.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jieyouxu @Kobzol @traviscross